Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@strawbrary
Copy link
Contributor

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

docs

Description of change

Update the link to V8 since the current URL is now redirecting to their issue tracker

@mscdex mscdex added doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency. labels Mar 2, 2016
@bnoordhuis
Copy link
Member

LGTM but would you mind signing the commit with your real name? It's not required but it looks better in the changelog. I can do it for you when I land the PR.

https://code.google.com/p/v8/ redirects to the V8 issue tracker
@strawbrary
Copy link
Contributor Author

Whoops, should have it now.

@bnoordhuis
Copy link
Member

Landed in 4c724dd, thanks!

@bnoordhuis bnoordhuis closed this Mar 2, 2016
bnoordhuis pushed a commit that referenced this pull request Mar 2, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Fishrock123 Fishrock123 mentioned this pull request Mar 7, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
https://code.google.com/p/v8/ redirects to the V8 issue tracker

PR-URL: #5530
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.