Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@evanlucas
Copy link
Contributor

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

doc

Description of change

TSCP should be TCP

@ronkorving
Copy link
Contributor

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Feb 28, 2016

LGTM

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Feb 28, 2016
evanlucas added a commit to evanlucas/node that referenced this pull request Feb 29, 2016
TSCP should be TCP

PR-URL: nodejs#5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas closed this Feb 29, 2016
@evanlucas evanlucas deleted the cptypo branch February 29, 2016 11:37
@evanlucas
Copy link
Contributor Author

Landed in 3c79bbd. Thanks

@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
TSCP should be TCP

PR-URL: #5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
TSCP should be TCP

PR-URL: #5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
TSCP should be TCP

PR-URL: #5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
TSCP should be TCP

PR-URL: #5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.