Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel" #52772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MattiasBuelens wants to merge 1 commit into from
Closed

[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel" #52772

MattiasBuelens wants to merge 1 commit into from

Conversation

@MattiasBuelens
Copy link
Contributor

@MattiasBuelens MattiasBuelens commented May 1, 2024

Manual backport of #50126 to v20.x.

Fixes #49971

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2024

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels May 1, 2024
@debadree25 @MattiasBuelens
stream: implement TransformStream cleanup using "transformer.cancel"
d36fbc3 
Fixes: nodejs#49971
PR-URL: nodejs#50126
Backport-PR-URL: nodejs#52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MattiasBuelens MattiasBuelens force-pushed the backport-50126-to-v20.x branch 2 times, most recently from 207856f to d36fbc3 Compare May 1, 2024 10:32
@MattiasBuelens MattiasBuelens mentioned this pull request May 1, 2024
Closed
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58837/

mcollina
mcollina approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito
Copy link
Member

marco-ippolito commented May 16, 2024 •
edited
Loading

Landed in 3dd96f1fabf3

marco-ippolito pushed a commit that referenced this pull request May 16, 2024
@debadree25 @marco-ippolito
stream: implement TransformStream cleanup using "transformer.cancel"
3dd96f1 
Fixes: #49971
PR-URL: #50126
Backport-PR-URL: #52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MattiasBuelens MattiasBuelens deleted the backport-50126-to-v20.x branch May 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MattiasBuelens @nodejs-github-bot @marco-ippolito @mcollina @benjamingr @debadree25
Morty Proxy This is a proxified and sanitized view of the page, visit original site.