lib: reduce usage of self = this
#5231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, there are unnecessary `self = this`.
Contributor
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 21, 2016
Remove unnecessary `self = this`. PR-URL: #5231 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d2b93e5 |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
Remove unnecessary `self = this`. PR-URL: #5231 Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: lib/domain.js
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
Remove unnecessary `self = this`. PR-URL: #5231 Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
In the backporting of this to v4.x I've removed the changes to |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
Remove unnecessary `self = this`. PR-URL: #5231 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, there are unnecessary
self = this.