nodejs · cjihrig · Mar 9, 2024 · MoLow · Mar 9, 2024
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -89,7 +89,6 @@ function stopTest(timeout, signal) {
    disposeFunction = abortListener[SymbolDispose];
  } else {
    timer = setTimeout(() => deferred.resolve(), timeout);
-    timer.unref();

    ObjectDefineProperty(deferred, 'promise', {
      __proto__: null,

diff --git a/test/fixtures/test-runner/output/timeout_ref.js b/test/fixtures/test-runner/output/timeout_ref.js
@@ -0,0 +1,7 @@
+'use strict';
+const { test } = require('node:test');
+
-
+
+test('very long time out ref dosent freeze process', { timeout: 30 * 1e3 }, () => {});
-
+
+test('very long time out ref dosent freeze process', { timeout: 30 * 1e3 }, () => {});
+test('callback test that times out', { timeout: 1 }, (t, done) => {});
+test('promise test that times out', { timeout: 1 }, () => {
+  return new Promise(() => {});
+});
diff --git a/test/fixtures/test-runner/output/timeout_ref.snapshot b/test/fixtures/test-runner/output/timeout_ref.snapshot
@@ -0,0 +1,28 @@
+TAP version 13
+# Subtest: callback test that times out
+not ok 1 - callback test that times out
+  ---
+  duration_ms: *
+  location: '/test/fixtures/test-runner/output/timeout_ref.js:(LINE):1'
+  failureType: 'testTimeoutFailure'
+  error: 'test timed out after 1ms'
+  code: 'ERR_TEST_FAILURE'
+  ...
+# Subtest: promise test that times out
+not ok 2 - promise test that times out
+  ---
+  duration_ms: *
+  location: '/test/fixtures/test-runner/output/timeout_ref.js:(LINE):1'
+  failureType: 'testTimeoutFailure'
+  error: 'test timed out after 1ms'
+  code: 'ERR_TEST_FAILURE'
+  ...
+1..2
+# tests 2
+# suites 0
+# pass 0
+# fail 0
+# cancelled 2
+# skipped 0
+# todo 0
+# duration_ms *
diff --git a/test/parallel/test-runner-output.mjs b/test/parallel/test-runner-output.mjs
@@ -94,6 +94,7 @@ const tests = [
  { name: 'test-runner/output/hooks.js' },
  { name: 'test-runner/output/hooks_spec_reporter.js', transform: specTransform },
  { name: 'test-runner/output/timeout_in_before_each_should_not_affect_further_tests.js' },
+  { name: 'test-runner/output/timeout_ref.js' },
  { name: 'test-runner/output/hooks-with-no-global-test.js' },
  { name: 'test-runner/output/global-hooks-with-no-tests.js' },
  { name: 'test-runner/output/before-and-after-each-too-many-listeners.js' },