test: reduce number of repetition in test-heapdump-shadowrealm.js #50104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowRealm garbage-collection is covered in another test. Reduce the number of repetition in test-heapdump-shadowrealm.js trying to fix the flakiness of the test.
lpinca
approved these changes
Oct 9, 2023
Collaborator
24 tasks
anonrig
approved these changes
Oct 10, 2023
Collaborator
30 tasks
Collaborator
|
Landed in 224f3ae |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
ShadowRealm garbage-collection is covered in another test. Reduce the number of repetition in test-heapdump-shadowrealm.js trying to fix the flakiness of the test. PR-URL: nodejs#50104 Refs: nodejs#49572 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShadowRealm garbage-collection is covered in another test. Reduce the
number of repetition in test-heapdump-shadowrealm.js trying to fix the
flakiness of the test.
Refs: #49572