test: fix redeclared test-event-emitter-* vars #4985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/1480/ |
Member
Author
|
CI looks good except the one wonky host that was hopefully just a CI infra thing. Let's try again: |
Member
Author
|
CI was all good except for one host with unrelated build issues. Trying again: |
Member
Author
|
Keeping the faith: |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 3, 2016
PR-URL: nodejs#4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Member
Author
|
Landed in 7ea34fd |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.