[v18.x backport] fs: add a fast-path for readFileSync utf-8 #49693
Closed
H4ad wants to merge 6 commits intonodejs:v18.x-stagingnodejs/node:v18.x-stagingfrom
Closed
[v18.x backport] fs: add a fast-path for readFileSync utf-8 #49693H4ad wants to merge 6 commits intonodejs:v18.x-stagingnodejs/node:v18.x-stagingfrom
H4ad wants to merge 6 commits intonodejs:v18.x-stagingnodejs/node:v18.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
Member
|
Hey, I'm sorry but a lot of commit landed on the staging branch since you opened this backport and now it has conflicts. |
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
fccbb41 to
cc7b552
Compare
Member
|
@nodejs/lts / @nodejs/releasers Now that Node.js 18 is in maintenance I think the risks of this backport PR outweigh potential benefits. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48658
cc @anonrig