Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Apr 19, 2023

This is an automated update of googletest to 9b12f74.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Apr 19, 2023
@tniessen
Copy link
Member

This was created by a manually triggered GitHub action. I'd suggest to keep this PR open for a bit since the update is not urgent and I want to see if we can improve how the action updates existing PRs.

Refs: #47482

@tniessen tniessen added the blocked PRs that are blocked by other issues or PRs. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to d25e625 deps: update googletest to bb2941f May 14, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to bb2941f deps: update googletest to cb455a7 May 21, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to cb455a7 deps: update googletest to 4580469 May 28, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to 4580469 deps: update googletest to 06f44bc Jun 4, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to 06f44bc deps: update googletest to 65cfeca Jun 11, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update googletest to 65cfeca deps: update googletest to 9b12f74 Jun 18, 2023
@lpinca
Copy link
Member

lpinca commented Jun 23, 2023

It has been updated a few times, should this still be blocked?

@lpinca
Copy link
Member

lpinca commented Jun 23, 2023

There are two commits though, I think that is not correct.

@tniessen
Copy link
Member

There are two commits though, I think that is not correct.

See gr2m/create-or-update-pull-request-action#555.

@tniessen tniessen removed the blocked PRs that are blocked by other issues or PRs. label Jun 24, 2023
@tniessen
Copy link
Member

I am going to close this PR and delete the branch so that the next workflow run will create a fresh PR.

@tniessen tniessen closed this Jun 24, 2023
@tniessen tniessen deleted the actions/tools-update-googletest branch June 24, 2023 16:09
@tniessen
Copy link
Member

Superseded by #48538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.