Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@targos
Copy link
Member

@targos targos commented Apr 13, 2023

@targos targos added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v14.x labels Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 13, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Today's answer to life the universe and everything is 6728!!
Off-course, this is wrong ...
..
What's a fish without eyes? A fsh!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐠

@richardlau
Copy link
Member

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5307/

I'm not sure if the v8-updates/test-linux-perf test failure is a flake, real failure or consequence of having to rebuild perf on the benchmark machines after they were upgraded to Ubuntu 22.04.

11:40:33 not ok 2 v8-updates/test-linux-perf
11:40:33   ---
11:40:33   duration_ms: 2317.68200
11:40:33   severity: fail
11:40:33   exitcode: 1
11:40:33   stack: |-
11:40:33     node:assert:399
11:40:33         throw err;
11:40:33         ^
11:40:33     
11:40:33     AssertionError [ERR_ASSERTION]: Couldn't find interpreted functionOne()

@targos
Copy link
Member Author

targos commented Apr 13, 2023

I've certainly seen this failure before, so probably a flake.
Rebuild: https://ci.nodejs.org/job/node-test-commit-v8-linux/5308/

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5314/

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit b8c7a1e into nodejs:main Apr 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b8c7a1e

targos added a commit that referenced this pull request May 2, 2023
Refs: v8/v8@11.3.244.4...11.3.244.8
PR-URL: #47536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.