Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tools: notify on Slack when invalid commit lands #47178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 23, 2023
Merged

tools: notify on Slack when invalid commit lands #47178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94c284
tools: notify on Slack when invalid commit lands
aduh95 Mar 20, 2023
4c694a1
Apply suggestions from code review
aduh95 Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@aduh95 @legendecas @Trott
3 people authored Mar 22, 2023
commit 4c694a1d614b2ac2fa206a9f781ba9bc80f9f04d
3 changes: 2 additions & 1 deletion 3 .github/workflows/notify-on-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
branches:
- main

name: Notify on Force Push
name: Notify on Push
permissions:
contents: read

Expand All @@ -26,6 +26,7 @@ jobs:
After: <https://github.com/${{ github.repository }}/commit/${{ github.event.after }}|${{ github.event.after }}>
SLACK_USERNAME: nodejs-bot
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

notifyOnMissingMetadata:
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
name: Notify on Push on `main` that lacks metadata
if: github.repository == 'nodejs/node'
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.