Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jan 11, 2016

fork is imported twice in a row. Remove duplication.

`fork` is imported twice in a row. Remove duplication.
@Trott Trott added the test Issues and PRs related to the tests. label Jan 11, 2016
@jbergstroem
Copy link
Member

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 12, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 12, 2016

LGTM

2 similar comments
@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2016

LGTM

@targos
Copy link
Member

targos commented Jan 12, 2016

LGTM

targos pushed a commit that referenced this pull request Jan 12, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@targos
Copy link
Member

targos commented Jan 12, 2016

landed in 0f3d75e

@targos targos closed this Jan 12, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 12, 2016
@MylesBorins
Copy link
Contributor

another fix has already landed on LTS making this one moot. Adding to ignore list

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: nodejs#4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott Trott deleted the redecl-fork branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.