dgram: prevent disabled optimization of bind() #4613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Have you thought about refactoring it to not use |
Contributor
Author
|
I went for minimal impact on this one. shrug |
Contributor
|
Well, LGTM either way. |
Contributor
|
LGTM, but would it be cleaner to just do |
Contributor
Author
|
@cjihrig |
Contributor
|
I don't think it should make a difference in that case. |
Member
|
LGTM if CI is green |
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized.
a2b4c49 to
2ffd365
Compare
Contributor
Author
|
Updated PR to simplify things as suggested. CI again for fun: https://ci.nodejs.org/job/node-test-pull-request/1216/ |
Contributor
|
Ah, much better. LGTM. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Jan 13, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: #4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 88b2889 |
rvagg
pushed a commit
that referenced
this pull request
Jan 14, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: #4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: #4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: #4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: nodejs#4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: nodejs#4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized. PR-URL: nodejs#4613 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reassigning a named parameter while also using the arguments object causes the entire function to never be optimized.