node-api: disambiguate napi_add_finalizer #45401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
77df31f to
c4d496b
Compare
mhdawson
reviewed
Dec 2, 2022
mhdawson
reviewed
Dec 2, 2022
mhdawson
approved these changes
Dec 2, 2022
Member
mhdawson
left a comment
There was a problem hiding this comment.
One small suggestion, but otherwise looks good to me.
eaae589 to
ce5f9ab
Compare
Collaborator
This was referenced Dec 7, 2022
Collaborator
Member
|
@legendecas looks like this needs a rebase now. |
14 tasks
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call.
ce5f9ab to
b04b070
Compare
Collaborator
Collaborator
Member
Author
|
@mhdawson rebased. Would you mind taking a look again? thank you! |
This was referenced Dec 21, 2022
Collaborator
legendecas
added a commit
that referenced
this pull request
Jan 4, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
Author
|
Landed in 198d203 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: nodejs#45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
Jan 21, 2023
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_add_finalizer doesn't support any operations related to
napi_wrap. Remove the ambiguous statements in the doc about
napi_wrap and avoid reusing the v8impl::Wrap call.