doc: improvement dgram.markdown copy #4437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
s/improvement/improvements to/ |
Member
Author
|
@mscdex ... will update on commit message log either when it lands or when I push additional edits |
Member
|
Minor, non-blocking nit: It might be clearer to use the term "datagram messages" rather than "datagrams" for the sake of people that are new to UDP/Datagram and not familiar with that terminology. @nodejs/documentation Thoughts? Other than that, LGTM. |
doc/api/dgram.markdown
Outdated
| ## Class: dgram.Socket | ||
|
|
||
| The dgram Socket class encapsulates the datagram functionality. It | ||
| should be created via [`dgram.createSocket(...)`][] | ||
| The `dgram.Socket` object is an [`EventEmitter`] that encapsulates the datagram |
Contributor
There was a problem hiding this comment.
were you intending on this being a link?
Member
Author
|
@Qard and @evanlucas ... nits addressed |
General improvements to dgram.markdown copy
ab3e866 to
24b266d
Compare
Member
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Jan 4, 2016
General improvements to dgram.markdown copy PR-URL: #4437 Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
Member
Author
|
Landed in 7e985d8 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
General improvements to dgram.markdown copy PR-URL: nodejs#4437 Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
jasnell
added a commit
that referenced
this pull request
Jan 7, 2016
General improvements to dgram.markdown copy PR-URL: #4437 Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
General improvements to dgram.markdown copy PR-URL: #4437 Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
General improvements to dgram.markdown copy PR-URL: nodejs#4437 Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to dgram.markdown copy