Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

doc: add src/crypto to CC list for nodejs/crypto #43286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 1, 2022
Merged

doc: add src/crypto to CC list for nodejs/crypto #43286

nodejs-github-bot merged 1 commit into from
Jun 1, 2022

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jun 1, 2022

src/node_crypto.* has been refactored into many smaller files that are in src/crypto.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 1, 2022

Review requested:

  • @nodejs/tsc

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen
Copy link
Member Author

tniessen commented Jun 1, 2022

Also, @nodejs/crypto has very few active members who frequently review C++ changes, and we often have changes that require C++ knowledge but not so much crypto-specific knowledge. Maybe we should have a team to ping for C++ changes that do not require familiarity with a specific subsystem?

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0ef81d1 into nodejs:master Jun 1, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 1, 2022

Landed in 0ef81d1

This was referenced Jun 2, 2022
Merged
Closed
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
@tniessen @italojs
doc: add src/crypto to CC list for nodejs/crypto
1766313 
PR-URL: nodejs#43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@tniessen @danielleadams
doc: add src/crypto to CC list for nodejs/crypto
5119a27 
PR-URL: #43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@tniessen @danielleadams
doc: add src/crypto to CC list for nodejs/crypto
5a3a2a1 
PR-URL: #43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: add src/crypto to CC list for nodejs/crypto
72e80ad 
PR-URL: #43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: add src/crypto to CC list for nodejs/crypto
b34fce7 
PR-URL: #43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: add src/crypto to CC list for nodejs/crypto
42a07f4 
PR-URL: nodejs/node#43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marsonya marsonya marsonya approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @nodejs-github-bot @lpinca @richardlau @aduh95 @marsonya
Morty Proxy This is a proxified and sanitized view of the page, visit original site.