Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v14.x backport] child_process: queue pending messages #42840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ErickWendel wants to merge 1 commit into from
Closed

[v14.x backport] child_process: queue pending messages #42840

ErickWendel wants to merge 1 commit into from

Conversation

@ErickWendel
Copy link
Member

@ErickWendel ErickWendel commented Apr 23, 2022

Backport of #41221

It fixes the problem of the child process not receiving messages.

Fixes: #41134

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. v14.x labels Apr 23, 2022
@ErickWendel
child_process: queue pending messages
1046464 
It fixes the problem of the child process not receiving messages.

Fixes: nodejs#41134
@ErickWendel ErickWendel force-pushed the backport-41221-to-v14.x branch from 80058dd to 1046464 Compare April 23, 2022 15:52
@ErickWendel ErickWendel marked this pull request as ready for review April 23, 2022 16:55
@aduh95 aduh95 mentioned this pull request Apr 28, 2022
Merged
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43754/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2022 •
edited by juanarbol
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/43758/ (:heavy_check_mark:)

juanarbol pushed a commit that referenced this pull request May 1, 2022
@ErickWendel @juanarbol
child_process: queue pending messages
4203d13 
It fixes the problem of the child process not receiving messages.

Fixes: #41134

PR-URL: #41221
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: #42840
@juanarbol
Copy link
Member

juanarbol commented May 2, 2022

Landed in 4203d13 🎉

@juanarbol juanarbol closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

+1 more reviewer

@danielleadams danielleadams danielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ErickWendel @nodejs-github-bot @juanarbol @danielleadams @aduh95
Morty Proxy This is a proxified and sanitized view of the page, visit original site.