Fix deprecation message for ErrnoException #4269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, good catch. I believe this is your first contribution to core, thanks for making the effort and welcome on board! @indutny pls review |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 14, 2015
Fix copy paste error in deprecation message PR-URL: #4269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Member
|
Landed in c311b61. @gagern ... thank you for the fix! one quick note, When I landed the commit I went ahead and fixed up the commit log message. Next time can I ask that you take a look at the commit log style guidelines here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
Fix copy paste error in deprecation message PR-URL: #4269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
Fix copy paste error in deprecation message PR-URL: #4269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Fix copy paste error in deprecation message PR-URL: #4269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Fix copy paste error in deprecation message PR-URL: nodejs#4269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that 75adde0 did a copy & paste mistake here. It doesn't make much sense to me to internally forward to the isolate-aware version of
ErrnoExceptionbut suggest callees useUVExceptioninstead.