Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 26, 2022

Buffer.bytelength() has an undocumented third parameterm mustMatch.
Remove it.

Closes: #38536

Buffer.bytelength() has an undocumented third parameterm `mustMatch`.
Remove it.

Closes: nodejs#38536
@Trott Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 26, 2022
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Mar 26, 2022
@Trott
Copy link
Member Author

Trott commented Mar 26, 2022

Duplicative of #38545

@Trott Trott closed this Mar 26, 2022
@Trott Trott deleted the mustMatch branch March 26, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buffer.byteLength's implementation is not consistent with the documentation

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.