Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: mark test-worker-take-heapsnapshot flaky #41253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhdawson wants to merge 2 commits into from
Closed

test: mark test-worker-take-heapsnapshot flaky #41253

mhdawson wants to merge 2 commits into from

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Dec 20, 2021

  • Mark test-worker-take-heapsnapshot as flaky on
    arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
test: mark test-worker-take-heapsnapshot flaky
85c96e3 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: nodejs#41204
Refs: nodejs#41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 20, 2021
@mhdawson mhdawson mentioned this pull request Dec 20, 2021
Open
@mhdawson
Copy link
Member Author

mhdawson commented Dec 21, 2021

Would like to request a fast track on this.

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2021

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41575/

cjihrig
cjihrig approved these changes Dec 21, 2021
View reviewed changes
test/pummel/pummel.status Outdated Show resolved Hide resolved
@mhdawson @cjihrig
Update test/pummel/pummel.status
0d740ab 
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41596/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41598/

@github-actions github-actions bot mentioned this pull request Dec 22, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41615/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41617/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41618/

mhdawson added a commit that referenced this pull request Dec 22, 2021
@mhdawson
test: mark test-worker-take-heapsnapshot flaky
96a6326 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Dec 22, 2021

Landed in 96a6326

@mhdawson mhdawson closed this Dec 22, 2021
This was referenced Dec 23, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 30, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson @targos
test: mark test-worker-take-heapsnapshot flaky
fac0871 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@mhdawson @danielleadams
test: mark test-worker-take-heapsnapshot flaky
55fb3d3 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@mhdawson @Linkgoron
test: mark test-worker-take-heapsnapshot flaky
b428af2 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: nodejs#41204
Refs: nodejs#41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
test: mark test-worker-take-heapsnapshot flaky
a53399e 
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson @nodejs-github-bot @jasnell @cjihrig
Morty Proxy This is a proxified and sanitized view of the page, visit original site.