util,src: allow lookup of hidden values #3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/node_util.cc
Outdated
Contributor
There was a problem hiding this comment.
If you've already verified the type then simply use .As<TYPE>()
Contributor
|
one comment, and if CI is happy then LGTM. |
Member
|
LGTM with the same comment as Trevor. |
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/833/ UPDATE: CI looked like it had some unrelated issues. One more run, just to be sure: https://ci.nodejs.org/job/node-test-pull-request/836/ |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Nov 24, 2015
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: nodejs#3988 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
@cjihrig ... is this a candidate for LTS? |
Contributor
Author
|
This PR alone is of little use in LTS. It only introduces a new internal method. It should be grouped in with #4013. |
Member
|
why is github showing zero commits and zero changes here? I believe that 5169311 on master comes from here but it's hard to be sure. |
Member
|
Oh interesting. That is very strange. |
Contributor
Author
|
Seems to be a result of landing a commit and then force pushing this branch to close the PR. Probably shouldn't do that anymore. |
cjihrig
added a commit
that referenced
this pull request
Dec 5, 2015
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: #3988 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Dec 8, 2015
Closed
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: nodejs#3988 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: lib/internal/util.js
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: #3988 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: lib/internal/util.js
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) #4166 * build - add "--partly-static" build options (Super Zheng) #4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) #4013 - display error message when loading directory (Prince J Wesley) #4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) #3988
MylesBorins
pushed a commit
that referenced
this pull request
Jan 20, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) #4166 * build - add "--partly-static" build options (Super Zheng) #4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) #4013 - display error message when loading directory (Prince J Wesley) #4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) #3988 PR-URL: #4768
MylesBorins
pushed a commit
that referenced
this pull request
Jan 20, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) #4166 * build - add "--partly-static" build options (Super Zheng) #4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) #4013 - display error message when loading directory (Prince J Wesley) #4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) #3988 PR-URL: #4768
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) nodejs#4166 * build - add "--partly-static" build options (Super Zheng) nodejs#4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) nodejs#4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) nodejs#4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) nodejs#4013 - display error message when loading directory (Prince J Wesley) nodejs#4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) nodejs#3988 PR-URL: nodejs#4768
This was referenced Nov 29, 2023
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS.
I'd like to use this to more easily access the hidden
arrowMessageassociated with syntax errors. Refs #3784, #3411, #2762