Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v14.x-backport] report: generates report on threads with no isolates #39515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
legendecas wants to merge 2 commits into from
Closed

[v14.x-backport] report: generates report on threads with no isolates #39515

legendecas wants to merge 2 commits into from

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Jul 25, 2021 •
edited
Loading

This backport contains following commits:

report: generates report on threads with no isolates

PR-URL: #38994
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com

src: fix fatal errors when a current isolate not exist

napi_fatal_error and node watchdog trigger fatal error but rather
running on a thread that hold no current isolate.

PR-URL: #38624
Reviewed-By: Michael Dawson midawson@redhat.com

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. v14.x labels Jul 25, 2021
@legendecas legendecas requested review from cjihrig, gireeshpunathil and himself65 and removed request for cjihrig and gireeshpunathil July 25, 2021 16:42
@legendecas legendecas force-pushed the backport-to-14/38994 branch from bfb6773 to 60b98e8 Compare July 25, 2021 16:47
@legendecas legendecas requested a review from mhdawson July 25, 2021 16:49
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39259/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39263/

@legendecas legendecas added node-api Issues and PRs related to the Node-API. and removed node-api Issues and PRs related to the Node-API. labels Jul 26, 2021
@targos
Copy link
Member

targos commented Aug 8, 2021

Can you please rebase?

@targos
Copy link
Member

targos commented Aug 29, 2021

ping @legendecas

@legendecas legendecas force-pushed the backport-to-14/38994 branch from 60b98e8 to 550f5d9 Compare August 30, 2021 16:08
@legendecas
Copy link
Member Author

legendecas commented Aug 30, 2021

@targos updated! :)

@legendecas @targos
src: fix fatal errors when a current isolate not exist
8384e3a 
napi_fatal_error and node watchdog trigger fatal error but rather
running on a thread that hold no current isolate.

PR-URL: nodejs#38624
Reviewed-By: Michael Dawson <midawson@redhat.com>
@legendecas @targos
report: generates report on threads with no isolates
3cab19c 
PR-URL: nodejs#38994
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos force-pushed the backport-to-14/38994 branch from 550f5d9 to 3cab19c Compare September 1, 2021 17:33
targos pushed a commit that referenced this pull request Sep 3, 2021
@legendecas @targos
src: fix fatal errors when a current isolate not exist
99493b0 
napi_fatal_error and node watchdog trigger fatal error but rather
running on a thread that hold no current isolate.

PR-URL: #38624
Backport-PR-URL: #39515
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 3, 2021
@legendecas @targos
report: generates report on threads with no isolates
f69c934 
PR-URL: #38994
Backport-PR-URL: #39515
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Sep 3, 2021

Landed in a74032a...f69c934

@targos targos closed this Sep 3, 2021
@legendecas legendecas deleted the backport-to-14/38994 branch March 25, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himself65 himself65 Awaiting requested review from himself65

@cjihrig cjihrig Awaiting requested review from cjihrig

@gireeshpunathil gireeshpunathil Awaiting requested review from gireeshpunathil

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas @nodejs-github-bot @targos
Morty Proxy This is a proxified and sanitized view of the page, visit original site.