timers: remove redundant unref calls #38320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Apr 20, 2021
Contributor
Author
|
Hey @jasnell, thanks for the quick review. I have a question tho. Does my change actually change something other than a redundant call (and state changes)? I tried looking around, but I couldn't find a reason for it to be actually meaningful 🧐 (other than of course not doing something redundant). |
benjamingr
approved these changes
Apr 21, 2021
Collaborator
Collaborator
Collaborator
Trott
approved these changes
Apr 24, 2021
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM but we probably need a perf benchmark. Will start one in a moment.
Member
Member
No significant changes in benchmark performance. |
Collaborator
PR-URL: nodejs#38320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
63c6270 to
d9b56fe
Compare
Member
|
Landed in d9b56fe |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant calls to
Timeout.unref()by passing theref: booleanparameter oftimers/promises#setTimeoutandtimers/promises#setIntervaldirectly toTimeoutconstructor'sisRefedparameter.Note: possible expansion of this PR is to apply the same
isRefedparameter from
TimeouttoImmediateto prevent the same redundantImmediate.unref()call intimers/promises#setImmediate.