Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v12.x] node-api: define version 8 #37796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardlau merged 1 commit into from
Mar 19, 2021
Merged

[v12.x] node-api: define version 8 #37796

richardlau merged 1 commit into from
Mar 19, 2021

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Mar 18, 2021

Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Reviewed-By: @Flarna
Reviewed-By: @mhdawson
Reviewed-By: @legendecas

@gabrielschulhof gabrielschulhof added c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. node-api Issues and PRs related to the Node-API. v12.x labels Mar 18, 2021
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 18, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36780/

@richardlau richardlau mentioned this pull request Mar 18, 2021
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36782/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36785/ (✅)

mhdawson
mhdawson approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36792/

@gabrielschulhof @richardlau
node-api: define version 8
93dd799 
Mark as stable the APIs that define Node-API version 8.

PR-URL: nodejs#37652
Backport-PR-URL: nodejs#37796
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@richardlau richardlau force-pushed the backport-node-api-8-to-v12.x branch from 8a3773b to 93dd799 Compare March 19, 2021 12:28
@richardlau
Copy link
Member

richardlau commented Mar 19, 2021

Landed in 93dd799

@richardlau richardlau merged commit 93dd799 into nodejs:v12.x-staging Mar 19, 2021
This was referenced Apr 18, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Apr 18, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 18, 2023
Open
This was referenced Apr 19, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Apr 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Flarna Flarna Flarna approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

@addaleax addaleax Awaiting requested review from addaleax

@codebytere codebytere Awaiting requested review from codebytere

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gabrielschulhof @nodejs-github-bot @richardlau @BethGriggs @legendecas @mhdawson @Flarna
Morty Proxy This is a proxified and sanitized view of the page, visit original site.