Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Trott
Copy link
Member

@Trott Trott commented Feb 8, 2021

This is a prerequisite for #37259.

Please 馃憤 to fast-track to unblock #37259.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 8, 2021
@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

This change is a lint-tool-only change so I think GitHub CI is sufficient (since it runs the linter). If someone disagrees and thinks Jenkins CI is required too, please say something. Thanks.

This is a prerequisite for nodejs#37259.

PR-URL: nodejs#37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@Trott Trott force-pushed the lint-preset-2.0.1 branch from adff367 to 72f9c53 Compare February 8, 2021 12:26
@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

Landed in 72f9c53"

@Trott Trott merged commit 72f9c53 into nodejs:master Feb 8, 2021
@Trott Trott deleted the lint-preset-2.0.1 branch February 8, 2021 12:27
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.