src: avoid implicit type conversions #37149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
reviewed
Jan 31, 2021
RaisinTen
approved these changes
Jan 31, 2021
Collaborator
benjamingr
approved these changes
Jan 31, 2021
Trott
approved these changes
Jan 31, 2021
jasnell
reviewed
Feb 1, 2021
jasnell
approved these changes
Feb 1, 2021
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM with exception to the mentioned change in ELDHistogram
Collaborator
Collaborator
This fixes a bunch of C4244 ('conversion' conversion from 'type1' to
'type2', possible loss of data) MSVC warnings in the code base.
PR-URL: nodejs#37149
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in b346cd1 |
targos
added a commit
to targos/node
that referenced
this pull request
Feb 12, 2021
This fixes more C4244 MSVC warnings in the code base. Refs: nodejs#37149
targos
added a commit
to targos/node
that referenced
this pull request
Feb 12, 2021
This fixes more C4244 MSVC warnings in the code base. Refs: nodejs#37149
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
This fixes a bunch of C4244 ('conversion' conversion from 'type1' to
'type2', possible loss of data) MSVC warnings in the code base.
PR-URL: #37149
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of C4244 ('conversion' conversion from 'type1' to
'type2', possible loss of data) MSVC warnings in the code base.