Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

lib: add SafeArray to primordials and use it for FreeList #36600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ExE-Boss wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

lib: add SafeArray to primordials and use it for FreeList #36600

ExE-Boss wants to merge 1 commit into from

Conversation

@ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Dec 22, 2020

Refs: #36304 (comment)
Refs: #36565

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@ExE-Boss ExE-Boss mentioned this pull request Dec 22, 2020
Closed
2 tasks
@Lxxyx
Copy link
Member

Lxxyx commented Dec 22, 2020

Run Benchmark on my computer, seems the performance issues still exists.

                           confidence improvement accuracy (*)    (**)   (***)
 misc/freelist.js n=100000        ***    -92.46 %      ±1.94% ±2.61% ±3.46%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

@aduh95
Copy link
Contributor

aduh95 commented Dec 22, 2020 •
edited
Loading

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/784/

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Dec 22, 2020

Looks like the benchmark CI crashed: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/783/console

aduh95
aduh95 requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark confirmed very poor performance results…

                            confidence improvement accuracy (*)   (**)  (***)
 misc/freelist.js n=100000        ***    -91.36 %       ±3.89% ±5.24% ±6.96%

@targos targos added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 27, 2020
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Mar 7, 2021 •
edited
Loading

If I had to guess, I’d say V8 is doing some inlining shenanigans when it detects a push or pop method on an ordinary array with %Array.prototype% in its [[Prototype]] internal slot.

By inlining the methods in #37649, I hope to make FreeList faster and resilient to mutation of %Array.prototype%.pop and %Array.prototype%.push

@ExE-Boss ExE-Boss mentioned this pull request Mar 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ExE-Boss @Lxxyx @aduh95 @targos
Morty Proxy This is a proxified and sanitized view of the page, visit original site.