doc: fix punctuation in v8.md #36192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two minor punctuation fixes for v8.md.
aduh95
approved these changes
Nov 20, 2020
jasnell
approved these changes
Nov 20, 2020
Member
|
+1 to fast-track |
lpinca
approved these changes
Nov 20, 2020
richardlau
approved these changes
Nov 20, 2020
Contributor
|
Landed in f47d655...2425589 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
Two minor punctuation fixes for v8.md. PR-URL: #36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Two minor punctuation fixes for v8.md. PR-URL: #36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
Two minor punctuation fixes for v8.md. PR-URL: #36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
Two minor punctuation fixes for v8.md. PR-URL: #36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2021
Two minor punctuation fixes for v8.md. PR-URL: #36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Two minor punctuation fixes for v8.md. PR-URL: nodejs#36192 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor punctuation fixes for v8.md.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes