doc: clarify that the ctx argument is optional #34097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: nodejs#34085
Member
Author
|
@nodejs/documentation @nodejs/crypto |
ryzokuken
approved these changes
Jun 28, 2020
Contributor
ryzokuken
left a comment
There was a problem hiding this comment.
Thanks for this, it's impossibly hard to spot.
mkrawczuk
reviewed
Jun 28, 2020
tniessen
approved these changes
Jun 28, 2020
trivikr
approved these changes
Jun 29, 2020
jasnell
approved these changes
Jul 3, 2020
jasnell
pushed a commit
that referenced
this pull request
Jul 3, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: #34085 PR-URL: #34097 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
LAnded in d2c8b3e |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: #34085 PR-URL: #34097 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: #34085 PR-URL: #34097 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is optional. Fixes: #34085 PR-URL: #34097 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that the
ctxargument of theSNICallbackcallback isoptional.
Fixes: #34085
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes