Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@NotMoni
Copy link
Contributor

@NotMoni NotMoni commented Mar 30, 2020

Checklist
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 30, 2020
@NotMoni NotMoni mentioned this pull request Mar 30, 2020
doc/guides/contributing/code-of-conduct.md Show resolved Hide resolved
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 1917ba8, thanks for the PR!

@addaleax addaleax closed this Apr 2, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
PR-URL: #32567
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@NotMoni NotMoni deleted the patch-1 branch April 2, 2020 23:48
@NotMoni
Copy link
Contributor Author

NotMoni commented Apr 2, 2020

@addaleax No problem. Looking 👀 to do more in the future
:D

BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
PR-URL: #32567
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
PR-URL: #32567
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #32567
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.