Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v12.x backport] stream: use more accurate end-of-stream writable and readable detection #31345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sxa wants to merge 1 commit into from
Closed

[v12.x backport] stream: use more accurate end-of-stream writable and readable detection #31345

sxa wants to merge 1 commit into from

Conversation

@sxa
Copy link
Member

@sxa sxa commented Jan 13, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

stream: use more accurate end-of-stream writable and readable detection
6c41057 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

PR-URL: nodejs#29409
Backport-PR-URL: nodejs#31345
targos pushed a commit that referenced this pull request Jan 14, 2020
@targos
stream: use more accurate end-of-stream writable and readable detection
536d088 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395
PR-URL: #29409
Backport-PR-URL: #31345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Jan 14, 2020

Landed in 536d088. Thank you!

@targos targos closed this Jan 14, 2020
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@BethGriggs
stream: use more accurate end-of-stream writable and readable detection
369b7c2 
The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.

Refs: #29395
PR-URL: #29409
Backport-PR-URL: #31345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sxa @targos @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.