lib/tls: replace var with let/const #30409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Nov 12, 2019
jasnell
approved these changes
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
| var offset = 0; | ||
| for (var i = 0, c = protocols.length; i < c; i++) { | ||
| let offset = 0; | ||
| for (let i = 0, c = protocols.length; i < c; i++) { |
Member
There was a problem hiding this comment.
nit: offset can be moved inside loop as follows:
Suggested change
| for (let i = 0, c = protocols.length; i < c; i++) { | |
| for (let offset = 0, i = 0, c = protocols.length; i < c; i++) { |
BridgeAR
approved these changes
Nov 13, 2019
Collaborator
gireeshpunathil
approved these changes
Nov 16, 2019
Collaborator
Collaborator
Collaborator
Member
|
with couple of nasty flakes in the CI, getting a coherent result has become tough. The last two runs (26910 and 26917) together bring us a good result. I assume that should be good, and use that premise to land (at least C&L) PRs. |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 24, 2019
PR-URL: #30409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed in 26b2655, thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes