doc: update Http2ServerRequest extends Readable #29253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Aug 21, 2019
Member
Author
lpinca
approved these changes
Aug 21, 2019
Member
Author
8daf178 to
d28eb8f
Compare
addaleax
approved these changes
Aug 21, 2019
Member
Author
Member
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3851/ Merge commit might mess it up. I'll rebase and re-run if so. |
5a5c1b6 to
3f1d9ed
Compare
Member
Trott
pushed a commit
that referenced
this pull request
Aug 23, 2019
PR-URL: #29253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in 31c3fc0 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the redundant statement explained by "extends stream.Readable"
Checklist