nodejs · himself65 · Jun 26, 2019 · Jun 26, 2019 · Jun 26, 2019
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -366,7 +366,6 @@ static void PrintJavaScriptStack(JSONWriter* writer,
  int line = ss.find('\n');
  if (line == -1) {
    writer->json_keyvalue("message", ss);
-    writer->json_objectend();
  } else {
    std::string l = ss.substr(0, line);
    writer->json_keyvalue("message", l);
@@ -382,8 +381,8 @@ static void PrintJavaScriptStack(JSONWriter* writer,
      ss = ss.substr(line + 1);
      line = ss.find('\n');
    }
+    writer->json_arrayend();
  }
-  writer->json_arrayend();
  writer->json_objectend();
 }


diff --git a/test/report/test-report-getreport.js b/test/report/test-report-getreport.js
@@ -21,6 +21,14 @@ common.expectWarning('ExperimentalWarning',
  assert.deepStrictEqual(helper.findReports(process.pid, process.cwd()), []);
 }

+{
+  // Test with an error with one line stack
+  const error = new Error();
+  error.stack = 'only one line';
+  helper.validateContent(process.report.getReport(error));
+  assert.deepStrictEqual(helper.findReports(process.pid, process.cwd()), []);
+}
+
 // Test with an invalid error argument.
 [null, 1, Symbol(), function() {}, 'foo'].forEach((error) => {
  common.expectsError(() => {

diff --git a/test/report/test-report-writereport.js b/test/report/test-report-writereport.js
@@ -37,6 +37,14 @@ function validate() {
  validate();
 }

+{
+  // Test with an error with one line stack
+  const error = new Error();
+  error.stack = 'only one line';
+  process.report.writeReport(error);
+  validate();
+}
+
 {
  // Test with a file argument.
  const file = process.report.writeReport('custom-name-1.json');