test: do not use fixed port in async-hooks/test-httparser-reuse #28312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this was failing on machines which already had a service running on port 3000.
richardlau
approved these changes
Jun 20, 2019
cjihrig
approved these changes
Jun 20, 2019
Trott
approved these changes
Jun 20, 2019
Collaborator
jasnell
approved these changes
Jun 23, 2019
Collaborator
Member
|
Landed in bf7edaa |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 28, 2019
Otherwise this was failing on machines which already had a service running on port 3000. PR-URL: nodejs#28312 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Otherwise this was failing on machines which already had a service running on port 3000. PR-URL: #28312 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Otherwise this was failing on machines which already had a service running on port 3000. PR-URL: #28312 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this was failing on machines which already had a service
running on port 3000.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes