Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v8.x] n-api: implement date object #28301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

[v8.x] n-api: implement date object #28301

gabrielschulhof wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jun 19, 2019

Implements napi_create_date() as well as napi_is_date() to
allow working with JavaScript Date objects.

PR-URL: #25917

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jun 19, 2019
@gabrielschulhof gabrielschulhof changed the title n-api: implement date object [v8.x] n-api: implement date object Jun 19, 2019
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jun 19, 2019
richardlau
richardlau reviewed Jun 20, 2019
View reviewed changes
doc/api/n-api.md Outdated
#### napi_create_date
<!-- YAML
added: REPLACEME
napiVersion: 4
Copy link
Member

@richardlau richardlau Jun 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napiVersion shouldn't be set for experimental API's? #28330

Copy link
Contributor Author

@gabrielschulhof gabrielschulhof Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to land this as is and then backport #28330.

@mhdawson
Copy link
Member

mhdawson commented Jul 3, 2019

@gabrielschulhof I assume that is to keep future backports as clean as possible?

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Jul 12, 2019

@mhdawson yes.

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 17, 2019
Closed
@jarrodconnolly
n-api: implement date object
fb4786e 
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.

PR-URL: nodejs#25917
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Sep 2, 2019

Rebased.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25575/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25580/

@BethGriggs BethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 19, 2019
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Oct 13, 2019

v8.x will receive no further minor releases.

@gabrielschulhof gabrielschulhof deleted the backport-25917-to-v8.x branch October 13, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof @mhdawson @nodejs-github-bot @richardlau @BethGriggs @jarrodconnolly
Morty Proxy This is a proxified and sanitized view of the page, visit original site.