test: fix NODE_OPTIONS feature check #28225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration variable being tested is `true` if Node.js was compiled without support for NODE_OPTIONS.
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
sam-github
approved these changes
Jun 14, 2019
Trott
approved these changes
Jun 17, 2019
Contributor
|
Landed in 9bead0c. |
danbev
pushed a commit
that referenced
this pull request
Jun 17, 2019
The configuration variable being tested is `true` if Node.js was compiled without support for NODE_OPTIONS. PR-URL: #28225 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
The configuration variable being tested is `true` if Node.js was compiled without support for NODE_OPTIONS. PR-URL: #28225 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
The configuration variable being tested is `true` if Node.js was compiled without support for NODE_OPTIONS. PR-URL: #28225 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration variable being tested is
trueif Node.js wascompiled without support for NODE_OPTIONS.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes