perf_hooks,trace_events: use stricter equality #28166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to use loose equality on these checks because undefined is caught by the preceding typeof check.
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
lpinca
approved these changes
Jun 11, 2019
Trott
approved these changes
Jun 12, 2019
richardlau
approved these changes
Jun 12, 2019
gengjiawen
approved these changes
Jun 12, 2019
BridgeAR
approved these changes
Jun 12, 2019
jasnell
approved these changes
Jun 14, 2019
ZYSzys
approved these changes
Jun 16, 2019
Collaborator
Member
|
Landed in 2b8b230. |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Jun 16, 2019
There is no need to use loose equality on these checks because undefined is caught by the preceding typeof check. PR-URL: nodejs#28166 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
There is no need to use loose equality on these checks because undefined is caught by the preceding typeof check. PR-URL: #28166 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
There is no need to use loose equality on these checks because undefined is caught by the preceding typeof check. PR-URL: #28166 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to use loose equality on these checks because
undefinedis caught by the precedingtypeofcheck.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes