Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@indutny
Copy link
Member

@indutny indutny commented Jun 10, 2019

See: nodejs/llhttp#26

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @nodejs/http

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@addaleax addaleax added the http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. label Jun 10, 2019
@indutny
Copy link
Member Author

indutny commented Jun 12, 2019

Landed in c1f0cbe. Thank you!

This should be backported to v12, I think?

@indutny indutny closed this Jun 12, 2019
indutny added a commit that referenced this pull request Jun 12, 2019
See: nodejs/llhttp#26

PR-URL: #28154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@indutny indutny deleted the feature/update-llhttp-1.1.4 branch June 12, 2019 21:57
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
See: nodejs/llhttp#26

PR-URL: #28154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.