Specifying that an error will be raised when there is a directory at newPath #27963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
May 30, 2019
Co-Authored-By: mscdex <mscdex@users.noreply.github.com>
Trott
reviewed
May 30, 2019
Member
|
Welcome @andyalcantara, and thanks for the pull request! Looks good to me with a small modification. |
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
Member
ZYSzys
approved these changes
Jun 2, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PR-URL: nodejs#27963 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Member
|
Landed in e7ca398 |
Member
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Jun 3, 2019
PR-URL: #27963 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist