Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

lib: use console.log for TTY on Windows #27829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richardlau wants to merge 1 commit into from
Closed

lib: use console.log for TTY on Windows #27829

richardlau wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented May 22, 2019

ANSI sequences are emulated on Windows, so use console.log() for
TTY's on Windows instead of directly writing to the filedescriptor.

Fixes: #27819

This is an alternative to #27823,
which is a full revert.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
lib: use console.log for TTY on Windows
c7dabf0 
ANSI sequences are emulated on Windows, so use `console.log()` for
TTY's on Windows instead of directly writing to the filedescriptor.

Fixes: nodejs#27819
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3600

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label May 22, 2019
@richardlau richardlau mentioned this pull request May 22, 2019
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23281/

@richardlau richardlau mentioned this pull request May 22, 2019
Closed
@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2019

Since the original point of this change was to avoid using console.log(), is this intended to be a temporary fix?

@addaleax
Copy link
Member

addaleax commented May 22, 2019

I mean … I think I’d prefer #27823 and sticking with console.log() – print() is an optimization that doesn’t appear to be used in hot code, so I’d go with the variant that reduces code complexity the most…

@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2019

I would prefer the revert as well, but based on #27819 (comment), it seemed like this would be revisited again anyway. If we're going to stick with the revert, then let's go that route.

@richardlau
Copy link
Member Author

richardlau commented May 22, 2019

Let's go with the revert then 😄.

@richardlau richardlau closed this May 22, 2019
@richardlau richardlau deleted the fix-2b24ffae22 branch May 22, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node -p process.verions display issue on Windows Cmd

4 participants

@richardlau @nodejs-github-bot @cjihrig @addaleax
Morty Proxy This is a proxified and sanitized view of the page, visit original site.