Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

doc: add version info for types #27754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhdawson wants to merge 1 commit into from
Closed

doc: add version info for types #27754

mhdawson wants to merge 1 commit into from

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented May 17, 2019 •
edited
Loading

Add version info for types in N-API doc.

Fixes: ttps://github.com//issues/27486

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 17, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3554

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 17, 2019
@mhdawson
doc: add version info for types
024875e 
Add version info for types in N-API doc.

Fixes: nodejs#27486
BridgeAR
BridgeAR approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rubber-stamp LGTM

@Trott
Copy link
Member

Trott commented May 26, 2019

Landed in dd6481a

@Trott Trott closed this May 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 26, 2019
@mhdawson @Trott
doc: add version info for types
dd6481a 
Add version info for types in N-API doc.

PR-URL: nodejs#27754
Fixes: nodejs#27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
@mhdawson @targos
doc: add version info for types
85f505c 
Add version info for types in N-API doc.

PR-URL: #27754
Fixes: #27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
@mhdawson mhdawson deleted the napi-doc-again2 branch September 30, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson @nodejs-github-bot @Trott @BridgeAR
Morty Proxy This is a proxified and sanitized view of the page, visit original site.