crypto: improve error handling in parseKeyEncoding

This change only affects KeyObject.export(). PR-URL: #26455 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs · tniessen · Jan 26, 2019 · Mar 5, 2019 · Mar 15, 2019 · f539e1f4e0807713146b0ccea2061df14e7a28f5
commit f539e1f4e0807713146b0ccea2061df14e7a28f5
diff --git a/lib/internal/crypto/keys.js b/lib/internal/crypto/keys.js
@@ -172,6 +172,9 @@ function isStringOrBuffer(val) {
 }

 function parseKeyEncoding(enc, keyType, isPublic, objName) {
+  if (enc === null || typeof enc !== 'object')
+    throw new ERR_INVALID_ARG_TYPE('options', 'object', enc);
+
  const isInput = keyType === undefined;

  const {

diff --git a/test/parallel/test-crypto-key-objects.js b/test/parallel/test-crypto-key-objects.js
@@ -104,6 +104,16 @@ const privatePem = fixtures.readSync('test_rsa_privkey.pem', 'ascii');
  assert.strictEqual(derivedPublicKey.asymmetricKeyType, 'rsa');
  assert.strictEqual(derivedPublicKey.symmetricKeySize, undefined);

+  // Test exporting with an invalid options object, this should throw.
+  for (const opt of [undefined, null, 'foo', 0, NaN]) {
+    common.expectsError(() => publicKey.export(opt), {
+      type: TypeError,
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'The "options" argument must be of type object. Received type ' +
+               typeof opt
+    });
+  }
+
  const publicDER = publicKey.export({
    format: 'der',
    type: 'pkcs1'