worker: ignore --abort-on-uncaught-exception for terminate() #26111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Worker threads with `--abort-on-uncaught-exception`, do not abort the process when `worker.terminate()` is called.
Member
Author
Member
Author
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20793/ (:heavy_check_mark:) |
jasnell
approved these changes
Feb 15, 2019
Member
Author
|
/cc @nodejs/workers |
joyeecheung
approved these changes
Feb 18, 2019
Member
Author
|
Landed in 85b95cc |
addaleax
added a commit
that referenced
this pull request
Feb 18, 2019
When running Worker threads with `--abort-on-uncaught-exception`, do not abort the process when `worker.terminate()` is called. PR-URL: #26111 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 18, 2019
When running Worker threads with `--abort-on-uncaught-exception`, do not abort the process when `worker.terminate()` is called. PR-URL: #26111 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
When running Worker threads with `--abort-on-uncaught-exception`, do not abort the process when `worker.terminate()` is called. PR-URL: #26111 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Worker threads with
--abort-on-uncaught-exception,do not abort the process when
worker.terminate()is called.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes