Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: remove unused and unimplemented method in env.h #25699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 1 commit into from
Closed

src: remove unused and unimplemented method in env.h #25699

gengjiawen wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jan 25, 2019

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@gengjiawen
src: remove unused and unimplemented method in env.h
6c9bef8 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 25, 2019
@addaleax
Copy link
Member

addaleax commented Jan 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20329/

@addaleax
Copy link
Member

addaleax commented Jan 27, 2019

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/20361/

@Trott
Copy link
Member

Trott commented Jan 28, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20365/

@addaleax
Copy link
Member

addaleax commented Jan 28, 2019

Landed in dc843f5

@addaleax addaleax closed this Jan 28, 2019
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@gengjiawen @addaleax
src: remove unused and unimplemented method in env.h
dc843f5 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25699
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@gengjiawen @addaleax
src: remove unused and unimplemented method in env.h
86e79a5 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25699
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen @addaleax @Trott @jasnell @cjihrig @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.