Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: do not leak NodeTraceStateObserver #25180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 2 commits into from
Closed

src: do not leak NodeTraceStateObserver #25180

addaleax wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Dec 22, 2018

This would otherwise be reported as a memory leak by automated tools.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: do not leak NodeTraceStateObserver
d7511c1 
This would otherwise be reported as a memory leak by automated tools.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2038/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 22, 2018
@addaleax addaleax added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Dec 22, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Dec 22, 2018 •
edited
Loading

The crashes look relevant?

assert.js:86
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'SIGILL'
- null
    at ChildProcess.CheckNoSignalAndErrorCodeOne (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-tracing-no-crash.js:7:10)
    at ChildProcess.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:373:15)
    at ChildProcess.emit (events.js:188:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)

joyeecheung
joyeecheung reviewed Dec 22, 2018
View reviewed changes
src/node.cc
// Destroy tracing after the platform (and platform threads) have been
// stopped.
tracing_agent_.reset(nullptr);
trace_state_observer_.reset(nullptr);
Copy link
Member

@joyeecheung joyeecheung Dec 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call controller->RemoveTraceStateObserver(trace_state_observer_.get()) here? (It's currently run in OnTraceEnabled but it may not be ever enabled?)

Copy link
Member Author

@addaleax addaleax Dec 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure, but does the controller still exist at this point?

@addaleax
Copy link
Member Author

addaleax commented Dec 22, 2018

@joyeecheung Thanks for pointing out the failures – afaict it was a double free for the cases where the tracing observer was enabled and cleaned up after itself. It might be nice to keep that behaviour, but I don’t think it’s important…

@addaleax
Copy link
Member Author

addaleax commented Dec 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19753/

@addaleax
Copy link
Member Author

addaleax commented Dec 26, 2018

Landed in b4145b8

@addaleax addaleax closed this Dec 26, 2018
@addaleax addaleax deleted the platform-trace-observer-memleak branch December 26, 2018 13:46
addaleax added a commit that referenced this pull request Dec 26, 2018
@addaleax
src: do not leak NodeTraceStateObserver
b4145b8 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
@addaleax @targos
src: do not leak NodeTraceStateObserver
7365b00 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src: do not leak NodeTraceStateObserver
64dfe81 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: nodejs#25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@addaleax @BethGriggs
src: do not leak NodeTraceStateObserver
7afcbcf 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@addaleax @BethGriggs
src: do not leak NodeTraceStateObserver
96a57a7 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@addaleax @BethGriggs
src: do not leak NodeTraceStateObserver
1fe0cc4 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
src: do not leak NodeTraceStateObserver
5d5ac23 
This would otherwise be reported as a memory leak by automated tools.

PR-URL: #25180
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @nodejs-github-bot @joyeecheung @richardlau
Morty Proxy This is a proxified and sanitized view of the page, visit original site.