Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: elevate v8 namespaces of referenced artifacts #24424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Nov 17, 2018
Merged

src: elevate v8 namespaces of referenced artifacts #24424

refack merged 1 commit into from
Nov 17, 2018

Conversation

@singhalkanika198
Copy link
Contributor

@singhalkanika198 singhalkanika198 commented Nov 17, 2018 •
edited by refack
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1649/

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018 •
edited
Loading

Hello @singhalkanika198 and welcome, and thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

@singhalkanika198 @refack
src: elevate v8 namespaces of referenced artifacts
451fb04 
PR-URL: nodejs#24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack force-pushed the elevate_v8_namespaces branch from 93d8930 to 451fb04 Compare November 17, 2018 19:21
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2018
@refack refack merged commit 451fb04 into nodejs:master Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018

@singhalkanika198 congratulation of getting promoted by GitHub from
image
to
image

🎉 Hope to see you contributing more in the future.

targos pushed a commit that referenced this pull request Nov 18, 2018
@singhalkanika198 @targos
src: elevate v8 namespaces of referenced artifacts
4b47795 
PR-URL: #24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@singhalkanika198 @rvagg
src: elevate v8 namespaces of referenced artifacts
b44623e 
PR-URL: #24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@singhalkanika198 @codebytere
src: elevate v8 namespaces of referenced artifacts
73bdb66 
PR-URL: #24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@singhalkanika198 @refack
src: elevate v8 namespaces of referenced artifacts
57abe05 
PR-URL: nodejs#24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@singhalkanika198 @codebytere
src: elevate v8 namespaces of referenced artifacts
fa52ba6 
PR-URL: #24424
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@singhalkanika198 @targos @refack @addaleax @gireeshpunathil @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.