os: fix memory leak in userInfo()
#23893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously leaked memory in the ‘success’ case.
Member
Author
targos
reviewed
Oct 26, 2018
src/node_os.cc
Outdated
| } | ||
|
|
||
| const int err = uv_os_get_passwd(&pwd); | ||
| OnScopeLeave free_passwd([&]() { uv_os_free_passwd(&pwd); }); |
Member
There was a problem hiding this comment.
is it safe to call it if uv_os_get_passwd returned an error?
Member
Author
There was a problem hiding this comment.
Yeah, I think you’re right, we shouldn’t do that. I’ve moved it below the conditional 👍
targos
approved these changes
Oct 26, 2018
cjihrig
approved these changes
Oct 26, 2018
richardlau
approved these changes
Oct 26, 2018
jasnell
approved these changes
Oct 26, 2018
Contributor
|
Landed in d690a87. |
danbev
pushed a commit
that referenced
this pull request
Oct 31, 2018
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
Contributor
|
Lands cleanly on 10 but not on 8 It would appear the leak actually doesn't exist on 8 so I'm marking as don't land |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 27, 2018
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This previously leaked memory in the ‘success’ case. PR-URL: #23893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously leaked memory in the ‘success’ case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes