Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

doc: fix 8.12.0 changelog #22803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MylesBorins wants to merge 1 commit into from
Closed

doc: fix 8.12.0 changelog #22803

MylesBorins wants to merge 1 commit into from

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Sep 11, 2018

currently fixed on master... apologies for the noise

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Sep 11, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 11, 2018

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/856/pipeline

MylesBorins added a commit that referenced this pull request Sep 25, 2018
@MylesBorins
doc: fix 8.12.0 changelog
b0d6067 
PR-URL: #22803
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 25, 2018

landed in b0d6067

@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@MylesBorins @nodejs-github-bot @lpinca @targos @cjihrig @tniessen @richardlau @trivikr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.