Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: more process moving #22758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 2 commits into from
Closed

src: more process moving #22758

jasnell wants to merge 2 commits into from

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Sep 7, 2018

Move GetActiveResources, GetActiveHandles, and the DebugPortGetter|Setter to node_process.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 7, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 7, 2018

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/829/pipeline

@refack refack added the process Issues and PRs related to the process subsystem. label Sep 8, 2018
@jasnell
Copy link
Member Author

jasnell commented Sep 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17144/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
@addaleax
Copy link
Member

addaleax commented Sep 14, 2018

Landed in efd4796, eaaee92

@addaleax addaleax closed this Sep 14, 2018
addaleax pushed a commit that referenced this pull request Sep 14, 2018
@jasnell @addaleax
src: move getActiveResources/Handles to node_process.cc
efd4796 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 14, 2018
@jasnell @addaleax
src: move DebugPortGetter/Setter to node_process.cc
eaaee92 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 15, 2018
@jasnell @targos
src: move getActiveResources/Handles to node_process.cc
878d616 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 15, 2018
@jasnell @targos
src: move DebugPortGetter/Setter to node_process.cc
27b0cb5 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@jasnell @targos
src: move getActiveResources/Handles to node_process.cc
e268b64 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 19, 2018
@jasnell @targos
src: move DebugPortGetter/Setter to node_process.cc
415eac8 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@jasnell @targos
src: move getActiveResources/Handles to node_process.cc
1d3a63f 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@jasnell @targos
src: move DebugPortGetter/Setter to node_process.cc
7e4f29f 
PR-URL: #22758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

+2 more reviewers

@refack refack refack approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell @nodejs-github-bot @addaleax @refack @devsnek
Morty Proxy This is a proxified and sanitized view of the page, visit original site.